solid_queue icon indicating copy to clipboard operation
solid_queue copied to clipboard

Remove redundant `run` methods in `SolidQueue::Processes`

Open yahonda opened this issue 1 year ago • 1 comments

This commit removes one of the redundant run methods in SolidQueue::Processes

Here are the warning messages appeared at Rails Nightly CI: https://buildkite.com/rails/rails-nightly/builds/1091#019244bc-9d36-476d-8924-5e2bea4cb728/1173-1176

/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:52: warning: method redefined; discarding old run
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:44: warning: previous definition of run was here

yahonda avatar Oct 01 '24 07:10 yahonda

The reason why this pull request removes this one is https://github.com/rails/solid_queue/pull/337 added the run method later.

yahonda avatar Oct 01 '24 07:10 yahonda

Thanks a lot @yahonda! 🙏 And thanks a lot to @byroot for merging this! I've been on-call the past week and it's been crazy busy so I hadn't had the time to tend to this repo 🙈 😳

rosa avatar Oct 06 '24 15:10 rosa