Removing a bot has some odd behaviour

[monorkin]

Discussed in https://github.com/basecamp/once-campfire/discussions/101

^{Originally posted by jacebenson October 27, 2025} Hey all,

I was messng with this project and thoguht I'd test out the bots. I added two n8n-test and n8n-prod. I was done so went the sever screen and removed them here. /account/edit

However if you remove them here... they arent removed here.

For them to be remove correctly it seems you need to remove them here. account/bots

Then clicking the "pencil" and then trash.

Is this something I can do some other way?

I searched for "bot" and "remove bot" the only topic that came up was some ai topic.

[milos-dukic]

hey @monorkin I can try to fix it

[monorkin]

If you have time, I'd appreciate the help @milos-dukic

[milos-dukic]

Update: So for this situation we have following steps:

1. Create a bot
2. And try to delete in "Gear box menu" or "Pencil menu"
3. This works fine

Now if you take following scenario:

1. Create a bot
2. Click on it (avatar) in the sidebar i.e. open the direct room with it (you don't have to type anything just open it)
3. Try to delete it from "Gear box menu" or "Pencil menu" and then we are stuck with this bug/issue
4. Practically it shows the directs which are not deleted upon bot deletion Btw those 2 delete buttons in "gear settings menu" and in "pencil menu" have same execution flow. Both of them eventually call deactivate method. "Gear settings" -> delete /account/users/:id -> user#destroy:

 def destroy
    @user.deactivate
    redirect_to edit_account_url
  end

"Pencil menu" -> delete /account/bots/:id -> bots#destroy:

  def destroy
    @bot.deactivate
    redirect_to account_bots_url
  end

Which end up calling deactivate in the User model.

Anyway, @monorkin sorry to bother you, but could we have some kind of rule/guide when raising bugs/issues, so that anyone could repro it without fiddling around if issue isn't reproducible from description. I think, if we could have some guide it would merit us all :). This is just a thought. Back to the bug...

EDIT: So @monorkin just one question, should the direct room be deleted along with the deleted user, or if you delete the user, direct rooms in which the deleted user was involved should stay? If the direct rooms should stay, then there is no bug :). Waiting for the answer, in order to proceed :)