omarchy icon indicating copy to clipboard operation
omarchy copied to clipboard

feat: Notification settings persist across theme changes

Open pipetogrep opened this issue 3 months ago • 3 comments

This PR separates the theme values from common settings in each theme's mako.ini. Common values are set in ~/config/mako/core.ini and then included per theme.

The main motivation for this was having a central location to set app specific mako preferences, and having them persist when changing themes.

pipetogrep avatar Sep 06 '25 20:09 pipetogrep

@pipetogrep This is nice to clean up some of those common elements. Looks like we just need a migration for this one though if you don't mind adding that.

ryanrhughes avatar Sep 06 '25 21:09 ryanrhughes

I can't believe I missed this! I had it in my head that mako didn't have includes? Or maybe it was AI that put that there!

dhh avatar Sep 07 '25 18:09 dhh

Given that we can do this, I think we should actually put all of this inside Omarchy. The ~/.config/mako/config file should just have includes to the files inside of ~/.config/omarchy/current/theme/mako.ini, then that file can include ~/.local/share/omarchy/default/mako/core.ini.

dhh avatar Sep 07 '25 18:09 dhh

I've tested this locally and ran the migration to simulate an upgrade, everything seems ok. Would appreciate further testing :)

My test involves seeing if my addition of silencing Plexamp notifications in core.ini works after a theme change.

Useful commands:

pkill mako || makoctl reload
notify-send "Test Title" "This is a test notification from Mako"

Arch wiki entry on mako's supported configurations

pipetogrep avatar Sep 09 '25 10:09 pipetogrep