mission_control-jobs icon indicating copy to clipboard operation
mission_control-jobs copied to clipboard

Allow filtering workers by hostname, name or even by configuration/queues

Open rosa opened this issue 1 year ago • 11 comments

Right now we don't have any filters for workers. With a few hundreds of workers, finding the ones you want becomes a bit tricky, and more so if we add #28. It'd be nice to filter them just like we filter jobs.

rosa avatar Jan 29 '24 16:01 rosa

I'd like to work on this issue.

jaredholdcroft avatar Jan 31 '24 10:01 jaredholdcroft

hi, is anyone currently working on this? if not, I would like to give it a try :)

Xeitor avatar Mar 19 '24 12:03 Xeitor

Still me! I was waiting for https://github.com/basecamp/mission_control-jobs/issues/28 and then got busy. Hoping to have a PR done this weekend.

jaredholdcroft avatar Mar 19 '24 13:03 jaredholdcroft

sure no problem

Xeitor avatar Mar 19 '24 13:03 Xeitor

hey! anyone currently working on this issue? Looks like a good one to get started on this project and I would love to give it a try

matiassalles99 avatar Apr 02 '24 04:04 matiassalles99

I've unassigned myself, life got in the way of this unfortunately.

jaredholdcroft avatar Apr 03 '24 19:04 jaredholdcroft

🙁 sorry to hear that. I can take a look at it throughout this week, I should have something ready to review by Sat/Sun

matiassalles99 avatar Apr 03 '24 22:04 matiassalles99

hi @matiassalles99, I took de liberty to open a PR draft since I did some work with jobs filters and this was pretty similar

Xeitor avatar Apr 10 '24 19:04 Xeitor

@Xeitor sg, I added name and hostname filters a couple of days ago but didn't open a PR - feel free to grab any changes from my branch if they come in handy (https://github.com/rails/mission_control-jobs/compare/main...matiassalles99:mission_control-jobs:worker-filters?expand=1)

matiassalles99 avatar Apr 10 '24 19:04 matiassalles99

ohh sorry @matiassalles99, you can go ahead and submit yours

Xeitor avatar Apr 10 '24 22:04 Xeitor

@Xeitor nah it's fine don't worry, I can take a look at another issue 💪

matiassalles99 avatar Apr 11 '24 14:04 matiassalles99