mission_control-jobs icon indicating copy to clipboard operation
mission_control-jobs copied to clipboard

Workers filters

Open Xeitor opened this issue 10 months ago • 5 comments

Pending

  • [x] filter by hostname
  • [x] filter by name
  • [ ] filter by configuration/queues

Closes: #29

Xeitor avatar Apr 10 '24 19:04 Xeitor

hey @rosa, hope you are doing great, when you have some time, I would like to hear your thoughts about the configuration/queues filter

I was thinking about making some kind of dynamic form so the user can input many key/value pair of attributes

Xeitor avatar Apr 11 '24 17:04 Xeitor

update: i was checking the solid_queue codebase and seems like workers metadata field can only have polling_interval, queues and thread_pool_size, if that is the case we could add the three of them as different inputs for now

Xeitor avatar Apr 13 '24 17:04 Xeitor

@Xeitor, I'm so sorry for the huge delay on this one 😳 I've been so busy with other stuff that I had to leave this gem quite unattended for a while, but I'm going to catch up this week.

i was checking the solid_queue codebase and seems like workers metadata field can only have polling_interval, queues and thread_pool_size, if that is the case we could add the three of them as different inputs for now

I think I'd like to keep this as generic as possible, so that we can also build support for resque and other backends easily. I think the only field that makes sense to filter by there is queues.

rosa avatar Jun 06 '24 15:06 rosa

@rosa no worries!! I guessed you were busy so no problem really :)

Xeitor avatar Jun 06 '24 19:06 Xeitor

@rosa I've just realized the queues filter is a little trickier than I thought

because the metadata is a text attr, we'll not be able to query it from the db, instead we'll have to perform the filter in memory, but I'll need to modify the enumerable logic similar to JobsRelation#perform_each

Xeitor avatar Jun 12 '24 17:06 Xeitor