marginalia icon indicating copy to clipboard operation
marginalia copied to clipboard

Doesn't work on next Rails

Open ghiculescu opened this issue 1 year ago • 2 comments

Since https://github.com/rails/rails/pull/52428, Marginalia doesn't work on some queries. I think the fix is to alias internal_exec_query instead of exec_query here. Does that sound right to you @byroot ? (Presumably same goes for update/deletes.)

ghiculescu avatar Aug 05 '24 02:08 ghiculescu

Marginalia is deprecated in favor of https://api.rubyonrails.org/classes/ActiveRecord/QueryLogs.html, I don't see much point making it compatible with Rails 8.0.

byroot avatar Aug 05 '24 07:08 byroot

I guess it’s time to switch over 😿

ghiculescu avatar Aug 05 '24 10:08 ghiculescu

@noahhl, I recommend this issue be closed.

jerzygangi avatar May 01 '25 13:05 jerzygangi