Bumped dotenv to 3.1

Open igor-alexandrov opened this issue 1 year ago • 3 comments

Closing #899.

Jul 31 '24 09:07 igor-alexandrov

@igor-alexandrov - dotenv 3.0.0 has breaking changes - see https://github.com/bkeepers/dotenv/releases/tag/v3.0.0.

This one might hit people especially - "\n is no longer expanded into a newline in quoted strings. Use multi-line strings with real line breaks, or set DOTENV_LINEBREAK_MODE=legacy to preserve the old behavior".

So I think we'll save this change for Kamal 2.0.

Aug 26 '24 10:08 djmb

@djmb maybe I am missing something, but I doubt that this change may hit people using Kamal. What examples do you have in mind?

Anyway, if you think that this change is for 2.0, I am fine with this. I already provided a workaround for the issue in #899.

Aug 26 '24 10:08 igor-alexandrov

@igor-alexandrov Looks like this was done in https://github.com/basecamp/kamal/pull/924/files#diff-7c2750e7045b7ddc6644f16f09b6690ad88e45b73bf747e14a1a0bf563c0f156R18

Sep 10 '24 12:09 morgoth

Closing this since it is not relevant anymore for Kamal 2.

Sep 25 '24 08:09 igor-alexandrov