kamal icon indicating copy to clipboard operation
kamal copied to clipboard

kamal proxy boot_config get/reset not working without parameters

Open claasz opened this issue 1 year ago • 4 comments

CLI

$ kamal proxy boot_config reset --https-port
No value provided for option '--https-port'

$ kamal proxy boot_config get --https-port
No value provided for option '--https-port'

From my understanding, reset should reset config to the default value, get should show the active value. So why do I have to provide a value?

claasz avatar Dec 19 '24 09:12 claasz

You should be able to run kamal proxy boot_config reset or kamal proxy boot_config get without the --https-port.

djmb avatar Jan 10 '25 16:01 djmb

So it would be less confusing if the error message would be something like reset sub command allows no options instead of No value provided for option '--https-port'

claasz avatar Jan 10 '25 16:01 claasz

Yes good point! I'll re-open

djmb avatar Jan 14 '25 15:01 djmb

Hmm this will be tricky to fix - the parsing of the options happens in Thor before we get our hands on them. Not sure this is worth the effort of fixing.

Maybe though we should just have boot_config_set, boot_config_get and boot_config_reset.

djmb avatar Jan 20 '25 14:01 djmb