kamal icon indicating copy to clipboard operation
kamal copied to clipboard

Show hook-output by default

Open jdelStrother opened this issue 1 year ago • 6 comments

Previously hooks could write to stdout, but this wouldn't be visible unless -v was passed to increase the verbosity.

A number of the hook samples do this, so I'm assuming this is an oversight..?

I don't see any existing tests that cover output verbosity, let me know if there's a suitable place to add a test for this.

Fixes #1243

jdelStrother avatar Dec 11 '24 19:12 jdelStrother

Anything I can do to help get this merged?

jdelStrother avatar Jan 07 '25 10:01 jdelStrother

Hi there, thank you for this suggestion. I am also looking for this feature and agree that we should allow verbosity by default for hooks.

hktang avatar Feb 20 '25 08:02 hktang

I also just ran in this IMO rather unexpected behaviour and would like it also to show STDOUT output by default

smartygus avatar Feb 21 '25 15:02 smartygus

Turns out this is basically reverting https://github.com/basecamp/kamal/pull/752. @djmb could you share some more on the reasoning behind it? A lot of the sample hooks print to stdout, it seems like it's a useful place to print, eg, status checks or confirmation of what's getting deployed

jdelStrother avatar Apr 29 '25 18:04 jdelStrother

Very much needed.

supercobra avatar Jul 07 '25 19:07 supercobra

@djmb I would also love to see this merged.

exterm avatar Oct 08 '25 23:10 exterm