node icon indicating copy to clipboard operation
node copied to clipboard

fix(reth_entrypoint): add flashblocks to additional args instead of rewritting

Open mur-me opened this issue 1 month ago • 3 comments

Today I found an issue with additional args in reth entrypoint, one of my args want propagate to the reth.

I've checked the code and found the root cause, ADDITIONAL_ARGS="--websocket-url=$RETH_FB_WEBSOCKET_URL" is completely rewriting the ADDITIONAL_ARGS value.

Funny, that pruning agrs don't have this issue

What was done:

  • add append instead of rewritting
  • add explicit echo

mur-me avatar Nov 11 '25 08:11 mur-me

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cb-heimdall avatar Nov 11 '25 08:11 cb-heimdall

This seems good. Could you rebase?

haardikk21 avatar Nov 12 '25 19:11 haardikk21

@haardikk21

This seems good. Could you rebase?

Done, thanks

mur-me avatar Nov 13 '25 08:11 mur-me