node icon indicating copy to clipboard operation
node copied to clipboard

fix(dependency_updater): prevent infinite pagination loop by checking NextPage before advancing

Open Fibonacci747 opened this issue 2 months ago • 2 comments

The previous pagination logic placed the resp.NextPage == 0 check in an unreachable else if branch competing with TagPrefix conditions. As a result, when TagPrefix != "" and no matching release is found on the last page, the code set options.Page = 0 and could loop indefinitely.

This change:

  • Moves the resp.NextPage == 0 termination check to run before assigning options.Page = resp.NextPage.
  • Removes the unreachable else if resp.NextPage == 0 branch.

The new flow follows the official go-github pagination example pattern, ensuring the loop exits correctly and preventing infinite iteration.

Fibonacci747 avatar Oct 26 '25 11:10 Fibonacci747

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cb-heimdall avatar Oct 26 '25 11:10 cb-heimdall

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 14 '25 14:11 github-actions[bot]

This pull request was closed because it has been inactive for 5 days since being marked as stale.

github-actions[bot] avatar Nov 22 '25 00:11 github-actions[bot]