node icon indicating copy to clipboard operation
node copied to clipboard

geth: respect HOST_IP env; remove override that broke --nat=extip

Open radik878 opened this issue 2 months ago • 2 comments

The entrypoint hard-set HOST_IP="" which overwrote any environment-provided value. As a result, the conditional that appends --nat=extip:$HOST_IP never executed, making it impossible to advertise a public IP even when HOST_IP was supplied via env. This fixes the issue by removing the overriding assignment and adding a clarifying comment to set HOST_IP via environment. Now, when HOST_IP is non-empty, --nat=extip is correctly applied; when unset/empty, it’s omitted.

radik878 avatar Oct 10 '25 10:10 radik878

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cb-heimdall avatar Oct 10 '25 10:10 cb-heimdall

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 14 '25 14:11 github-actions[bot]

This pull request was closed because it has been inactive for 5 days since being marked as stale.

github-actions[bot] avatar Nov 23 '25 00:11 github-actions[bot]