Bart van Andel
Bart van Andel
Unit tests failed due to #1706, which is apparently still flaky. Just ran them locally (after upgrading to [email protected] and [email protected]), all tests pass.
@a3957273 Quick, the tests now pass! 😉
Note to maintainers: I noticed that `glob` isn't installed as a direct dev dependency, but is being imported in `Gruntfile.js`. You may want to address that.
> Minor nitpick, the git commit body (the message) needs to split at 72/80 characters as well. Do you want 72 or 80?
Wrapped commit body at 72 chars as requested.
Just pushed a change to satisfy AppVeyor. Unfortunately Travis crashed before compilation even started. Anyway, any other changes you require before you decide to merge this pull request?
@ferventcoder I put some effort into this branch 22 to 15 months ago, you requested some changes which I resolved back then, but after that, silence... I can try to...
Weird. Codacy says there are 2 new issues, but when diving into the details by following the links you end up not seeing them in code. Also, Travis fails with...
Well, happy to contribute! I think it's probably fastest if you do the rebase, as you know better about what has changed than I do (I basically don't have a...
@ferventcoder any progress on this PR?