galaxy_blizzard_plugin icon indicating copy to clipboard operation
galaxy_blizzard_plugin copied to clipboard

Starcraft marked "Remastered" although offered in game as "can be purchased"

Open yoshimo opened this issue 5 years ago • 6 comments

Describe the bug Inside Starcraft it looks like this

grafik

The official launcher says: grafik

GoG marks this as:

grafik

I would assume the game being only marked as Classic Starcraft without the remastered tag, unless i really bought it.

yoshimo avatar Jun 13 '20 11:06 yoshimo

Looks impossible now: https://github.com/FriendsOfGalaxy/galaxy-integration-battlenet/issues/7

Need research, maybe listening Battlenet client or starcraft itself with Fiddler or stuff like that to discover endpoints that distinguish wheater you have remastered or not.

Then plugin may send to Galaxy 2 separate ids for those games.

bartok765 avatar Jun 15 '20 09:06 bartok765

This would be awesome. Is there a way to manually specify which one you want to have listed? I own the old anthology as well as remastered, but regular StarCraft is what gets linked. Ideally it would have both, but I understand why it is just pulling one. W3 and W3 Reforged shows both as installed, with the ability to launch both, but SC only shows normal SC and Remastered isn't showing as owned.

Swatseal avatar Dec 17 '20 21:12 Swatseal

I think we could use the shop api

https://eu.shop.battle.net/api/product/starcraft-remastered has blocks like

"eligibility": { "eligible": true, **"owned": false,** "upgrade": false, "discounted": false },

yoshimo avatar May 07 '21 09:05 yoshimo

Good finding! We need to ensure we have access with the plugin authorization cookies.

Maybe also #24 and #50 can be solved by checking this API. @yoshimo would you like to implement this? Some refactor will be needed probably.

bartok765 avatar May 10 '21 08:05 bartok765

I can supply samples but i'm not a coder I'm rather optimistic that the linked issues can be solved:

/api/product/call-of-duty-black-ops-4
/api/product/call-of-duty-modern-warfare-2-campaign-remastered
/api/product/crash-bandicoot-4
/api/product/diablo-ii
/api/product/diablo-ii-lord-of-destruction
/api/product/diablo_ii_resurrected
/api/product/hearthstone-battle-ready-decks
/api/product/hearthstone-tavern-pass
/api/product/starcraft-cartooned
/api/product/starcraft-ii-announcer-mengsk
/api/product/starcraft-ii-carbot-complete-bundle
/api/product/warcraft-iii-reforged
/api/product/world-of-warcraft-shadowlands

are in my log. Hardcoding products might not be the best idea ill have to dig a little deeper. https://eu.shop.battle.net/api/navigation Might help here with the destination tag.

yoshimo avatar May 10 '21 10:05 yoshimo

Great, I will try to code it in a spare time.

bartok765 avatar May 10 '21 13:05 bartok765