Bartek Iwańczuk

Results 361 comments of Bartek Iwańczuk

Does this problem persist on Deno v1.34?

> PTAL @bartlomieju @littledivy. Although this is probably not ready for merging, and the comments [#15760 (comment)](https://github.com/denoland/deno/pull/15760#issuecomment-1279953186) and [#15760 (comment)](https://github.com/denoland/deno/pull/15760#issuecomment-1281613105) are still things to fix, it would be good to...

Let's wait on https://github.com/denoland/deno/pull/17648 before we merge this PR.

@andreubotella looking at the benchmarks you provided there's about 0.3ms regression in the startup benchmark - it's something we'll need to address before landing. I'm gonna give a thorough review...

> > Could you remind me of the reason why we need `global_realm` to be an `Option`? If we removed the `Option` we could get rid of a lot of...

> > > Could you remind me of the reason why we need `global_realm` to be an `Option`? If we removed the `Option` we could get rid of a lot...

@piscisaureus suggested other solution. I will test it first on current `main` branch to see if it's feasible to use and let you know.

Yes, that sounds reasonable. PRs are welcome

CC @littledivy could you take a look at that? We should now support `disconnect` event in `ChildProcess`.

This is most likely caused by the fact that we don't set up proper entries in `node_modules/.bin/` directory.