betty icon indicating copy to clipboard operation
betty copied to clipboard

Generate resources based on template directories.

Open bartfeenstra opened this issue 4 years ago • 3 comments

This fixes https://github.com/bartfeenstra/betty/issues/155 and https://github.com/bartfeenstra/betty/issues/448

bartfeenstra avatar May 05 '20 09:05 bartfeenstra

Site generation is significantly slower than before, possibly due to more file I/O since we first copy all files to their destination, then render the tree which, for some renderers, skips their ability to render on copy.

bartfeenstra avatar May 07 '20 20:05 bartfeenstra

The problem is that this completely prevents us from adding fallback templates later, using jinja2.environment.Environment.select_template().

bartfeenstra avatar Sep 15 '20 23:09 bartfeenstra

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (d975004) 94.66% compared to head (2004843) 93.20%. Report is 559 commits behind head on 0.3.x.

:exclamation: Current head 2004843 differs from pull request most recent head 1866bfe. Consider uploading reports for the commit 1866bfe to get more accurate results

Files Patch % Lines
betty/render.py 79.00% 21 Missing :warning:
betty/fs.py 73.80% 11 Missing :warning:
betty/sass.py 58.82% 7 Missing :warning:
betty/jinja2.py 95.23% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x     #458      +/-   ##
==========================================
- Coverage   94.66%   93.20%   -1.47%     
==========================================
  Files          31       31              
  Lines        2381     2471      +90     
==========================================
+ Hits         2254     2303      +49     
- Misses        127      168      +41     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 08 '20 15:11 codecov[bot]