barter.vg
barter.vg copied to clipboard
Statistics go missing in phone view
When viewing offer statistics on a narrow screen, some of the numbers go missing.
Steps to reproduce the bug
- Go to any profile page, scroll down to the offer statistics.
- Compare the view with a narrow browser window vs a wide one (or compare phone view to that on a computer).
- Note that the bottom row (marked
>
) has one less number than the upper row.
Expected behavior
Both rows should contain the same info.
The fix
...is pretty easy - just ensure that both rows have the same columns set to collapse.
The html should look something like this:
<tr>
<th></th>
<th>Total</th>
<th>Declined</th>
<th class="collapse">Expired</th>
<th class="collapse">Accepted</th>
<th title="cancelled offers as a percentage of accepted offers">Cancelled</th>
<th title="failed offers, which do not include cancelled, as a percentage of accepted offers">Failed</th>
<th>Completed</th>
</tr>
<tr>
<th title="offers received"><</th>
<td>n</td>
<td title="n received offers declined">%</td>
<td class="collapse" title="n received offer expired">%</td>
<td class="collapse" title="n accepted (estimated)">n%</td>
<td title="n received offer agreed to cancel">n%</td>
<td title="n received failed">n%</td>
<td title="n% of received accepted offers completed, n% of all received offer completed">n</td>
</tr>
<tr>
<th title="offers sent">></th>
<td>n</td>
<td title="52 sent offers declined">63%</td>
<td class="collapse" title="n sent offers expired">n%</td>
<td class="collapse" title="n accepted (estimated)">n%</td>
<td title="n sent offer agreed to cancel">n%</td> // <--- note no class="collapse" here
<td title="n sent failed">0%</td>
<td title="n% of sent accepted offers completed, n% of all sent offers completed">n</td>
</tr>