Ruben Bartelink

Results 351 comments of Ruben Bartelink

Oh yeah, I remember that now 🤦 Will have a peep (there's another semantic in ATC about honoring cancellation too) You're not wrong about compile vs runtime semantic changes being...

Added a comment https://github.com/TheAngryByrd/IcedTasks/pull/24/files#r1556182882 TL;DR I don't think any deviations whatsoever from `AwaitTaskCorrect` are a good idea. I don't understand enough about what forces `AwaitAwaiter` is balancing to be able...

I think my conclusion/proposal is thus that the thing I'd do is remove the pieces that are bracketed with `#if !FABLE_COMPILER` for V5: https://github.com/demystifyfp/FsToolkit.ErrorHandling/blob/dccdbbc629a15dbb1ab8c795ca515364cc81bfc7/src/FsToolkit.ErrorHandling/AsyncResultCE.fs#L201-L217 https://github.com/demystifyfp/FsToolkit.ErrorHandling/blob/dccdbbc629a15dbb1ab8c795ca515364cc81bfc7/src/FsToolkit.ErrorHandling/AsyncResultCE.fs#L135-L142 Luckily I'm not the maintainer...

I don't see how this ever becomes manageable unless we figure out a unified policy and have a statement to refer people to. I'd say the basics are: - there...

@nblumhardt I guess it's too late now, but maybe a 5.0.1 that trims the netstandard2.1, net5.0 and net7.0 targets might still make sense? https://github.com/serilog/serilog-sinks-console/pull/145#pullrequestreview-1691901895

> I think the packages that just went out all align with the same TFMs as Serilog 3.1, True; I guess it's not a massive deal For avoidance of doubt,`Serilog.Sinks.File`...

Sad to see this closed @joesdu; it's definitely not my department but these problems do seem surmountable? Ultimately Nick is just asking these questions from the point of view of...

Good ideas - in the past I've had a desire to be able to flag Async Sink buffer overflows (i.e. notifying when events were being jetissoned) too - we had...

related: [a question referencing some implementations of same](https://stackoverflow.com/questions/77229219/serilog-specify-property-names-to-ignore-them-during-destructuring) As for whether something like this could/should be in the box, that's another question...

For issues like this, it's recommended to ask on StackOverflow.com, tagging it as `serilog`. That way you'll get a broad mix of people who understand Serilog, and the specific sink...