AndroidPdfViewer icon indicating copy to clipboard operation
AndroidPdfViewer copied to clipboard

AndroidX migration

Open TalbotGooday opened this issue 5 years ago • 9 comments

The support library artifacts are being deprecated and all future development is going into AndroidX, so there’s no point to avoiding this migration.

UPD: Full-migrated library is here https://github.com/TalbotGooday/AndroidPdfViewer. It also includes some forks from this repo

TalbotGooday avatar May 01 '20 11:05 TalbotGooday

It seems like current AndroidPdfViewer library doesn't support an application migrated to androidX. Is it right?

katie0809 avatar Jul 06 '20 02:07 katie0809

@katie0809 yeah, you are right. Here is a fork with AndroidX https://github.com/TalbotGooday/AndroidPdfViewer

implementation 'com.github.TalbotGooday:AndroidPdfViewer:3.1.0-beta.2'

TalbotGooday avatar Jul 06 '20 06:07 TalbotGooday

@TalbotGooday Thank you, actually I solved problems by adding maven { url 'https://maven.google.com' } to the build.gradle. And I don't know why...='(

katie0809 avatar Jul 06 '20 07:07 katie0809

@katie0809 so your problem was not the "migration problem")

TalbotGooday avatar Jul 06 '20 08:07 TalbotGooday

👍 look good to me :) @barteksc any chance to get this merged and forge a release?

madmas avatar Jul 14 '20 07:07 madmas

@TalbotGooday as there seems to be no update in this place, have you consider to continue your fork?

madmas avatar Aug 04 '20 13:08 madmas

@madmas it all depends on what desires the community will have) Feel free to create issues in my fork)

TalbotGooday avatar Aug 04 '20 13:08 TalbotGooday

@TalbotGooday thanks for the quick response :) actually, you don't have issues enabled: grafik

madmas avatar Aug 04 '20 15:08 madmas

@madmas oh, sorry. I will enable this option asap)

UPD: Done

TalbotGooday avatar Aug 04 '20 15:08 TalbotGooday