AndroidPdfViewer icon indicating copy to clipboard operation
AndroidPdfViewer copied to clipboard

Move handler creation to onAttachedToWindow() instead of the constructor

Open MimiReader opened this issue 6 years ago • 4 comments
trafficstars

Detaching and reattaching a PDFView causes an NPE. This is due to creating a handler in the constructor, but setting it to null in onDetachedFromWindow(). The fix is to create the handler on onAttachedToWindow() instead of the constructor.

This allows the view to be detached and re-attached without loss of functionality.

MimiReader avatar Sep 24 '19 22:09 MimiReader

+1 https://github.com/barteksc/AndroidPdfViewer/issues/822

wonday avatar Oct 09 '19 15:10 wonday

@barteksc could you merge this fix and create a new release please? It's a big blocker for people using your library in React Native: https://github.com/wonday/react-native-pdf 😿

barsumek avatar Mar 06 '20 09:03 barsumek

Is this update added in V3.2.0-beta.1? I am getting crash for this issue.

Shvet avatar Feb 16 '21 07:02 Shvet

Please add new feature for autoCropPageMargin on bitmap blank space

alambd34 avatar Mar 03 '22 02:03 alambd34