Bartek Szopka
Bartek Szopka
I'm afraid this won't work as needed. In Vanilla copying the static SCSS and HTML was enough to get good approximation of the changes from PR (but we already seen...
I looked into history and it seems that passing HTML directly into Chip was introduced here, where I think it was meant for selecting part of chip value as a...
Triage: low effort fix (just remove whitespace between buttons in Vanilla examples). Little downside (they would be a bit harder to read, as HTML formatting would be affected).
I was pretty sure we have some basic print styles, but I can't find any (apart from utility allowing you to hide things from print (https://vanillaframework.io/docs/utilities/no-print). I guess there is...
Triage: that is high effort, and quite high impact. That's probably something to consider for new architecture. We seem to consistently struggle with this. It seems that we need different...
I believe this is already in progress. So triaging as part of current codebase.
@jmuzina is this still relevant? I think we disabled scripting in combined examples, right?
Triage: indeed, I can reproduce it in Firefox. It doesn't happen in Chrome (button is focused, but not scrolled to). This should be fixed in current codebase.
For accessibility reasons modals have a code that brings focus inside them when opened. This seems to be causing issues in embedded examples. We still what the focusing to happen...
> I recognize most of the above aren't related to theming directly, but just wanted to capture them during this review. @pastelcyborg This is a weird component in Vanilla sense....