Bartek Szopka comments

Results 428 comments of


                                            Bartek Szopka

ActionButton should extend Button

Can be revisited during migration to new architecture.

Investigate components composition patterns

Triage: architecture level decision that should be revisited in new architecture of design system.

Define prop naming conventions

Thanks for bringing it up for discussion. I guess @huwshimi may correct me if needed, but that's some of the historical context of what we currently have. Overall react-components started...

Define prop naming conventions

@petermakowski I'm moving it to Icebox for now. Do you think there is anything actionable on it at this point?

Define prop naming conventions

Triage: That's a discussion that should be revisited when implementing new architecture and new React components.

Suggest using userEvent library instead of fireEvent for simulating user interaction

Triaging as consideration for new architecture.

Segmented Controls in React Vanilla

Triage: This can probably be moved to new architecture. If anyone will have an implementation to upstream in the meantime this can work as well.

Filter panel opens when a chip is removed

It will be discussed in WG in canonical-web-and-design/vanilla-framework#4076

Bundle up the dist to avoid missing dependency issues

@squidsoup @huwshimi TBH I have no idea where to even start looking into this. I even don't fully understand what the issue is, as I'm not using React components in...

Bundle up the dist to avoid missing dependency issues

Something to consider in new architecture of design system.