language-puppet icon indicating copy to clipboard operation
language-puppet copied to clipboard

Resource reference (in dependency statement) does not accept quoted string

Open PierreR opened this issue 9 years ago • 1 comments

I have an issue with the latest version of garethr-docker on the following code.

So upon:

    file { '/etc/sysconfig/docker-storage-setup':
      content => template('docker/etc/sysconfig/docker-storage-setup.erb'),
      before  => 'Service[docker]',
    }

language-puppet would emit this error:

ERROR: (docker/registry_testing) Expected a resource reference, not: Service[docker] at # ./modules/docker/manifests/service.pp:129:12%

As a first note, the error message is not helpful ;-)

What do you think language-puppet should do in this situation ?

  • emit a better error message ?
  • accept it in permissive mode but emit a better error message in strict mode
  • always accept it

PierreR avatar Feb 29 '16 13:02 PierreR

I think option 2 would be the best.

bartavelle avatar Feb 29 '16 14:02 bartavelle