Simon Marechal
Simon Marechal
How should be this new information be named? `subdivision_1` and `subdivision_2` as described in the [Maxmind docs](https://dev.maxmind.com/geoip/docs/databases/city-and-country?lang=en#locations-files)?
Should that information be filled with the ISO code, or the English name? I think the ISO code would be better, as the English name can contain non-ASCII character, for...
The filter part is merged, but not tested. Now the logging and configuration parts need to be done.
In the actual code, flow control happens before limit checks.
I would expect the "AND" behavior is not what users would want, especially for the `exclude` tag. The change itself is trivial. What do you think @ItaiPrajgrod @Aviv-Galmidi ?
I think all the matchers are case sensitive! I'll take a good look.
So absolutely all matching is case sensitive. Should I change the behavior, or should documentation be changed? If I change the behavior, there are a couple of things I must...
The change itself is not too complicated, but I am unsure if/where exactly it should happen, as there are many regexp matchers in curiefense. Also the Rust re library is...
@yanivreblaze agree, but what should be the behaviour? :)
Implemented host autotag in e67b964f722adbe93403df1f8f7c7f7833311ccf