Barry Hart
Barry Hart
I have a fix for this. There were multiple code issues involved. See #205.
I have a fix for this: #206.
@jpers36, @tunetheweb: Are we proposing that L052 should do this in **all** dialects, or only T-SQL?
I have a draft PR (#2610) which prototypes this change. TL;DR It's easy enough to find the end of each statement and add a semicolon.
@jpers36: Sure, if you like. I don't think it's working yet, though. Handling the last statement in the file is proving to be tricky -- I think I'm making progress,...
@jpers36: I have a mostly-working PR now. I tagged you on the test cases: when there are nested statements, it's adding/enforcing multiple semicolons. It looks weird, so I wanted to...
We're rolling back the PR #2610, which was buggy. The rule needs refactoring before we can try this again. Thus, reopening this issue.
I have not been contributing to the project recently.
Could one or more of the maintainers run this rule on a large set of real-world queries? I do like the rule, but we may see surprise warnings from it...
Are you potentially interested in contributing a PR? We have a shortage of contributors for dbt-specific fixes and enhancements nowadays.