laravel-ide-helper
laravel-ide-helper copied to clipboard
composer fix-style
Summary
As pointed out in https://github.com/barryvdh/laravel-ide-helper/pull/1557#issuecomment-2160730489 , there are pending changes from php-cs-fixer not being applied.
Let's apply them!
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
- [x] Misc. change (internal, infrastructure, maintenance, etc.)
Checklist
- [ ] Existing tests have been adapted and/or new tests have been added
- [ ] Add a CHANGELOG.md entry
- [ ] Update the README.md
- [x] Code style has been fixed via
composer fix-style
There's a workflow https://github.com/barryvdh/laravel-ide-helper/blob/master/.github/workflows/fix-code-style.yml but there are multiple reasons it actually does not work:
- it does not run on forks, so no user benefits from this usually
- in it current configuration it does run after a merge to master
- which it did last time, but because master is a protected branch, it can't push with the pure github token -> it would require a PAT
- but actually I wouldn't advise it to push to master anyway
For that to be useful it should be able to push on PRs, but 🤷🏼 how to achieve that.