laravel-ide-helper icon indicating copy to clipboard operation
laravel-ide-helper copied to clipboard

[3.x] Use official ReflectionDocBlock

Open barryvdh opened this issue 1 year ago • 2 comments

Summary

Try to avoid using the fork of ReflectionDocBlock.

The official lib still doesn't support changing the docs but it does support creating a new one..

Type of change

  • [x] Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • [ ] Existing tests have been adapted and/or new tests have been added
  • [ ] Add a CHANGELOG.md entry
  • [ ] Update the README.md
  • [ ] Code style has been fixed via composer fix-style

barryvdh avatar Feb 18 '24 10:02 barryvdh

Hmm it seems to show the classes for itself as FQN which is not really ideal probably.

barryvdh avatar Feb 18 '24 10:02 barryvdh

@mfn we can remove it for the Model collector at least, except there a few changes (see comments mostly). Not sure if we need to change those, but it would be nice if we could just use the upstream package.

But we would need to do the same for the other generator command still.

barryvdh avatar Feb 18 '24 12:02 barryvdh

Yeah I think the upstream lib doesn't handle generics like we want to. And in general, it tries to 'fix' this for us, which we don't really need..

barryvdh avatar Feb 19 '24 08:02 barryvdh

Hmm not really happy with this as-is. Might leave it to think about it, or explore alternatives (see #1511)

barryvdh avatar Feb 19 '24 12:02 barryvdh

Stumbled upon this. Would it be possible if we would update the barrryvdh/ReflectionDocBlock to the newest version and re-apply the needed modifications?

Especially this is kinda needed: Serializer::removeTrailingSpaces() PHPCs is biting my butt for those trailing spaces xD

func0der avatar May 16 '24 19:05 func0der