laravel-ide-helper icon indicating copy to clipboard operation
laravel-ide-helper copied to clipboard

Published 20 hours ago • verified publisher icon barryvdh

handle protected methods with the attribute syntax

Open mridul89 opened this issue 2 years ago • 5 comments

Summary

Laravel introduced a new syntax to define attribute "accessors / mutators" in https://github.com/laravel/framework/pull/40022
Support for this new syntax was added in https://github.com/barryvdh/laravel-ide-helper/pull/1289

However, laravel documentation asks to use protected methods, but #1289 only looked at the public methods. This PR will also include protected methods.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x] Add a CHANGELOG.md entry
  • [x] Code style has been fixed via composer fix-style
  • [x] Updated the existing test and the corresponding snapshot

mridul89 avatar Mar 04 '22 18:03 mridul89

@barryvdh I've tested this in our applications and it works perfectly. Could you look into this some time?

sforward avatar Aug 17 '22 08:08 sforward

@barryvdh can review this PR ?

keatliang2005 avatar Sep 27 '22 13:09 keatliang2005

FTR: this competes with #1339 which covers additional cases and is thus preferred

mfn avatar Feb 18 '23 20:02 mfn

I merged #1339 Does this solve your issue? @keatliang2005 @mridul89 @sforward

barryvdh avatar Feb 20 '23 08:02 barryvdh

I merged #1339 Does this solve your issue? @keatliang2005 @mridul89 @sforward

Hi,

#1531 is still pending, and may have been introduced by #1339. I don't know however if this one addresses that issue.

vpratfr avatar Apr 11 '24 13:04 vpratfr