laravel-dompdf icon indicating copy to clipboard operation
laravel-dompdf copied to clipboard

Proposal: Interface (contract)

Open pionl opened this issue 3 years ago • 1 comments

Hi,

would be OK if I make a pull request that would allow me to inject PDF instance using interface?

  • I would extract public functions from PDF to interface (contract), interface would by in Contracts folder.
  • I would register the interface to use dompdf.wrapper binding in ServiceProvider.

This would allow me two things:

  • interface dependency injection
  • Test my logic without real PDF implementation: No mockery, just a simple implementation of the contract.

Thank you, happy holidays and new year 💪

pionl avatar Dec 21 '22 17:12 pionl

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any issues with PDF rendering itself that are not directly related to this package, should be reported on https://github.com/dompdf/dompdf instead. When having doubts, please try to reproduce the issue with just dompdf. If you believe this is an actual issue with the latest version of laravel-dompdf, please reply to this issue so we can investigate further. Thank you for your contribution! Apologies for any delayed response on our side.

stale[bot] avatar Jun 18 '23 08:06 stale[bot]