Jordan Barrett

Results 40 comments of Jordan Barrett

@balchua I'll try that, thanks. How about making that timeout configurable, so users can find their own value that works?

Probably just an input to the action would be fine: ```yaml uses: balchua/microk8s-actions@1e8e626239c2befe7cd5d258c96ae152a7259c74 with: channel: "1.25-strict/stable" addons: '["dns", "hostpath-storage"]' timeout: 120s ```

I think 120s will still be too short in some cases. We are now running self-hosted runners which may have surfaced this issue. If things are ready before the timeout,...

@balchua I just tested v0.4.1, unfortunately it doesn't solve our issue. See some failed runs here: https://github.com/juju/juju/actions/runs/6171575601/job/16750097840?pr=16242 https://github.com/juju/juju/actions/runs/6171575585/job/16750097890?pr=16242 The first one in particular is really strange - getting what looks...

I get exactly the same problem when trying to install flyctl for the first time using the `install.sh` script. It also seems to be exactly the same issue as described...

Agreed, nothing here should be Discourse specific.

@hpidcock I agree, the vet check is a really nice thing to add in. However, we still have the same problem if the format string is not a constant. Even...

The issue is that we're breaking the contract of these methods: ``` // NotValidf returns an error which satisfies Is(err, NotValid) and the // Locationer interface. ``` This is incorrect...

@hpidcock @tlm just pushed a new version of this which patches the `MyErrorTypef` methods to return a correctly typed error. As a bonus: * the format string/args are passed directly...

> Kubernetes by itself runs a number of services that are waiting for requests to server and perform a number of periodic checks. It is therefore expected a server running...