Raffael Meyer

Results 184 comments of Raffael Meyer

@safwansamsudeen the reason and effect of the changes in this particular PR is still not obvious to me: what was the problem, what was the cause of the problem, what...

How about this approach: - All images dropped in Text Editor are stored as private files - Images contained in an email are made available publicly, but non-enumerable (https://github.com/frappe/frappe/pull/25094) and...

Somehow a translation used in unit tests got lost in the process. I re-added it in Crowdin (with a comment explaining it's use in tests), so if we sync again...

A thought on the "relink" functionality: the API call without perm checks doesn't seem safe. Maybe we could just make the reference doctype+name writable in the form and remove the...

Don't worry, your custom translations will continue to work. We only removed the outdated + incomplete + unused translation files. We also switched to Crowdin as our new translation platform:...

List view already takes user permissions into account, so should be mostly fine. But yeah, it will be tricky in many places. In some places `has_permission("My DocType")` means "can possibly...

This has no effect. We just make all available values from all Select field `options` translatable. The `is_translatable` checkbox only toggles a UI feature.

Check `gettext/extractors/doctype.py` for the code that is responsible for converting options to translatable strings.

Tested, works as expected. However, the _Translatable_ checkbox defaults to `False`. We don't store the default values in the JSON files. Your code works because it chooses _the opposite_ default...

Let's close this in favor of https://github.com/frappe/frappe/pull/26198? That's an easier hotfix for now. It achieves the same without repurposing the "translatable" attribute.