homu icon indicating copy to clipboard operation
homu copied to clipboard

We are experiencing weird commit re-writing with homu, which causes commits to be broken (not build wise)

Open matthiasbeyer opened this issue 9 years ago • 3 comments

Please have a look at the git history of https://github.com/matthiasbeyer/imag

Homu merged commits from @TheNeikos which are signed with GPG. Homu somehow re-writes these commits before merging. This results in the first two lines of the GPG signature to be removed, which breaks the whole commit.

The commit IDs are not the same anymore than from the hashes of the original commits, so we assume that humo rewrites commits.

Please fix this, we can not trust homu anymore and I will remove humo from my repository now because of this.

matthiasbeyer avatar Jan 22 '16 19:01 matthiasbeyer

I would like to also add that the commits were fine before: https://github.com/matthiasbeyer/imag/pull/125

She also does not actually merge the pr after pushing into master. This has been a problem for about 4-5 days, looking at your commit history it seems something broke.

TheNeikos avatar Jan 22 '16 19:01 TheNeikos

Why are we getting no response here, @barosl?

matthiasbeyer avatar Apr 22 '16 12:04 matthiasbeyer

we had the same issue here: https://github.com/projectatomic/atomic/commit/16450623ef6d429e5ff8291cb48c0c64e68eb481

The original commit was correctly GPG signed: https://github.com/giuseppe/atomic/commit/0165fa5173cd458d7f28183f54c82d1eb85ca66a

giuseppe avatar Jul 26 '16 17:07 giuseppe