mark2 icon indicating copy to clipboard operation
mark2 copied to clipboard

get_jvm_options treats 0/1 as true/false

Open mr2013 opened this issue 12 years ago • 1 comments

When using an option like java.cli.XX.ParallelGCThreads=1 in the config, the expected java parameter is -XX:ParallelGCThreads=1. Instead, the function treats the 1 as True, and sets the option to -XX:+ParallelGCThreads, thus rendering the JVM unable to start.

Suggested change, properties.py, line 172: Replace

if v in (True, False):

With

if v is True or v is False:

mr2013 avatar Aug 30 '13 03:08 mr2013

To make the intention here clearer, might I offer:

if type(v) == bool:

prophile avatar Oct 16 '13 13:10 prophile