Michael Morello comments

Results 126 comments of


                                            Michael Morello

[doc] Fix minUnavailable typo in PDB

`upgrade-test-harness` is intended for upgrade testing, not for documentation purposes, that's why I think we should keep it as what has been installed by users. The `docs/reference/api-reference` change is maybe...

[doc] Fix minUnavailable typo in PDB

buildkite test this please

[doc] Fix minUnavailable typo in PDB

buildkite test this please

Remove docs and unit tests surrounding running agent as non-root

> The agent container needs CAP_SETPCAP and CAP_CHOWN capabilities [...] > [...] > I'm wondering if there's still value in the init container approach for some users - where only...

Fix: Add owner reference to existing resources when initially missing

_I misinterpreted the code, marking this comment as off topic_

Fix: Add owner reference to existing resources when initially missing

I marked my previous comment as off topic but I still think we should not assume the first item in `expectedOwners` is the managing controller. ```go k8s.OverrideControllerReference(reconciledMeta, expectedOwners[0]) ```