mui-theme-creator
mui-theme-creator copied to clipboard
bareynol
Any plans to start working on upgrading to v5?
This is very interesting project. Just wanted to check if you have any plans to start looking into v5 support of material ui?
I do, along with some general UX upgrades. Unfortunately, that likely won't land on my plate until MUI v5 exits the pre-release stage.
I hope the current v4 variant will still be around as a lot of app maintainers won't be able to migrate to v5 in the near future.
I hope the current v4 variant will still be around
You can always fork it from its current state.
Now that Material-UI has officially released V5, yes!
Given my current bandwidth, I expect to start working on an update this weekend, and to complete it within about a month.
v4 support will not be removed.
On Fri., Sep. 24, 2021, 3:07 a.m. Joacim Nilsson, @.***> wrote:
@bareynol https://github.com/bareynol Any updates on this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bareynol/mui-theme-creator/issues/8#issuecomment-926397462, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWJIDEROAWPIZUKMWEAUNTUDQPUVANCNFSM46R5DXIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Hey there @bareynol! Is there any way we can get involved with the development of the new version? Do you need any help?
My apologies to everyone, and a big thanks to those offering to help (you guys/gals are the best). I've been navigating a change in jobs, and a few other things in life, so unfortunately my bandwidth has been limited, and my earlier estimate way off.
Progress on a few things is already underway (notably moving off of Gatsby, and sectioning the site to handle v4 and v5 of MUI).
I'll be adding some issues and milestones to plan out the rest of the transition throughout the week, and I'm hoping to get some base changes up this weekend. From there I'll be tackling things pretty passively, with help from anyone who wants to give it.
On Mon., Oct. 25, 2021, 7:18 a.m. tobtrie, @.***> wrote:
@bareynol https://github.com/bareynol Is there any update on this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bareynol/mui-theme-creator/issues/8#issuecomment-950816617, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWJIDAWIPZTKTJ4DI5GEVDUIU4HNANCNFSM46R5DXIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
@bareynol just discovered your site, would love to help with the V5 upgrade as well 😊
Been using MUI v5 as well. Wondering if there is any timeframe on when it ill be available?...
@bareynol I just discovered this impressive tool! Thanks for making it! I'm also interested in helping with the v5 support as well. I have some colleagues that might be able to pitch in too. It'd be really cool if the MUI team could devote some resources to it or have something similar. It makes for a fantastic UX, especially for people that are new to MUI. Thanks again!
I would also be up for helping, if you still need it.
I'll open a PR with the project migrated to MUI V5 if you want.
The PR #12 added support for MUI v5.
@bareynol doesn't seem to be active anymore, so in the meantime, the new version is available from my fork on https://zenoo.github.io/mui-theme-creator/
The PR #12 added support for MUI v5. @bareynol doesn't seem to be active anymore, so in the meantime, the new version is available from my fork on https://zenoo.github.io/mui-theme-creator/
Thanks for forking this amazing tool and upgrading it to MUI v5!!
I tried the app at https://zenoo.github.io/mui-theme-creator/ but when I change the default and paper background colors, the background no longer changes when I flip the light/dark switch.
And I tried checking out https://github.com/Zenoo/mui-theme-creator to run it locally but when I run yarn start, I get this error: ModuleNotFoundError: Module not found: Error: Can't resolve 'src/components/SavedThemes/DefaultThemes'
Any idea why flipping the background with the theme type or why running the code locally doesn't work?
@lolero That's the usual behavior, even on the main theme creator.
As soon as you customize a color, it stays like this, light or dark theme in place.
You can reset your color though.
I can't say for sure why you can't run the code on your end, everything seems fine on mine
@lolero That's the usual behavior, even on the main theme creator. As soon as you customize a color, it stays like this, light or dark theme in place. You can reset your color though.
I can't say for sure why you can't run the code on your end, everything seems fine on mine
Thanks for the quick reply!
Is there a way to set colors for the background and the text so that they change when the type param on the theme toggles between light and dark?
You can define two themes (which is the way themes work in MUI too, you switch from one to the other).
Set everything you want in your first theme, save it in the Saved themes tab, then create your second one and save it too.
You can now switch between them.
@Ou7law007 They work for me, can you open an issue on my fork describing your issue?
unable to add below values to ThemeOptions as it is not in the key in Interface
props: { MuiTooltip: { arrow: true, }, },
below is working components: { MuiTooltip: { defaultProps: { arrow: true }, }, },
The PR #12 added support for MUI v5. @bareynol doesn't seem to be active anymore, so in the meantime, the new version is available from my fork on https://zenoo.github.io/mui-theme-creator/
the real MVP
