mui-theme-creator icon indicating copy to clipboard operation
mui-theme-creator copied to clipboard

Published 20 hours ago • verified publisher icon bareynol

MUI v5

Open Zenoo opened this issue 2 years ago • 10 comments

This PR works on bringing MUI v5 to the repo.

I'm having some issues with the ts config for this repo:

I'm also fixing some Typescript issues as I see them.
I will update this PR when the upgrade is done.

Zenoo avatar Apr 06 '22 14:04 Zenoo

The main work is done.
All there is left is removing every useStyles and replacing them with the sx prop.
I'm doing that right now.

Another error I can't seem to fix is in the website editor:

Zenoo avatar Apr 06 '22 17:04 Zenoo

Alright, I fixed the error in the Monaco editor.
Only the usestyles left.

Zenoo avatar Apr 06 '22 20:04 Zenoo

Everything should be done!

Zenoo avatar Apr 07 '22 08:04 Zenoo

This looks really sweet @bareynol any plans to merge this and give users the option to swap between v4 and v5?

shadoath avatar Sep 03 '22 16:09 shadoath

@shadoath You can already do that by accessing the usual URL for v4, and the URL from my fork for v5

Zenoo avatar Sep 03 '22 17:09 Zenoo

@Zenoo thank you I have bookmarked your repo!

Looking at the number of changes I now realize that there is no way to have both the v4 and v5 MUI active at the same time.

shadoath avatar Sep 06 '22 12:09 shadoath

I mde a fork and fixed a few minor things for v5, but im a github noob so dont know what to do with it. Its here https://github.com/vfproductions/mui-theme-creator

vfproductions avatar Sep 06 '22 16:09 vfproductions

@vfproductions You can imply open a PR on my fork https://github.com/Zenoo/mui-theme-creator/pulls

Zenoo avatar Sep 06 '22 18:09 Zenoo

@Zenoo yep nevermnind.. I already did that, and you completed it, and it's showing up here, so all is good. Just not used to seeing commits in ascending order. Weird

vfproductions avatar Sep 06 '22 18:09 vfproductions

I did have one more small thing to PR, see https://github.com/Zenoo/mui-theme-creator/pull/4

vfproductions avatar Sep 06 '22 19:09 vfproductions