org-dashboard icon indicating copy to clipboard operation
org-dashboard copied to clipboard

Published 20 hours ago • verified publisher icon bard

Some fixes

Open kstarsinic opened this issue 9 years ago • 7 comments

  • List items erroneously display as their parent headline *** Project [0/2]
    • [ ] Task 1 [1/2]
      • [-] Subtask 1
      • [-] Subtask 2
    • [ ] Task 2 * Shows as ***** [[myfile::Project][Project]] [ ] 0% ** [[myfile::Project][Project]] [████████████████ ] 50% ** After this patch, it shows as ***** [[myfile::Project][Project]] [ ] 0% **** [[myfile::Project][Task 1]] [████████████████ ] 50% *** NOTES ***** Uses "text search" link instead of "heading search" link, so it's not necessarily a unique match ***** It would be great to have an option to prefer line number links, id: links, or elisp: links
  • Ignore cookies in table entries | Here in a table [1/10] |
  • "Arithmetic error" when denominator is 0 *** Task [0/0]
  • Handle links in headlines *** [[this]] is misparsed

kstarsinic avatar Jul 04 '15 16:07 kstarsinic

Thanks!

Can you give an example of the case the first case refers to? The one you wrote got garbled up by the formatting engine.

(Please, in the future, one PR per fix/feature.)

bard avatar Jul 04 '15 18:07 bard

Here's the example:

  • Project [0/2]
    • Task 1 [1/2]
      • Subtask 1
      • Subtask 2

When we scanned "Task 1 [1/2]", we were calling org-get-heading, which returned "Project" instead of "Task 1".

I'll be sure to stick to one PR per pull request in the future.

kstarsinic avatar Jul 05 '15 23:07 kstarsinic

Hi, are you looking for any more information on this pull request?

kstarsinic avatar Jul 31 '15 14:07 kstarsinic

No, thanks for checking and sorry for not getting around to merging yet. Just waiting for a time window to go through the changes, verify them and make individual commits. A matter of days hopefully.

bard avatar Jul 31 '15 14:07 bard

@kstarsinic does navigating from links in *Org Dashboard* to org files work for you, when the link was created from a heading that in turn contains a link (e.g. * TODO see [[http://www.google.com][google]]), or do you also get a No match, do you want to create the heading message?

Edit: I see your patch takes that into account already.

bard avatar Aug 11 '15 18:08 bard

Also I'm debating whether it makes sense to support all possible elements where a progress cookie might appear. I'd be rather inclined to restrict the scope to headings only.

bard avatar Aug 12 '15 08:08 bard

@bard navigating from those links works for me, which I believe you agree with now. As to restricting the scope, I feel that if I put a progress cookie there, I'd want to see it in the dashboard. I can see your point, though, but if you don't want to show list items (which are the only additional elements that can have progress cookies), then I think their progress should be rolled up to their parent element, and the parent element displayed in the dashboard.

kstarsinic avatar Aug 13 '15 22:08 kstarsinic