php-console icon indicating copy to clipboard operation
php-console copied to clipboard

Published 20 hours ago • verified publisher icon barbushin

Remove unncessary final, fixes PHP 8 compatibility

Open Seldaek opened this issue 4 years ago • 1 comments

Using this library on PHP 8 leads to this warning:

PHP Warning: Private methods cannot be final as they are never overridden by other classes in vendor/php-console/php-console/src/PhpConsole/Connector.php on line 101

This PR fixes that in a less intrusive way than #171

closes #171

Seldaek avatar Dec 09 '20 13:12 Seldaek

@barbushin if you have a few minutes to merge and tag a release for this it'd be great.

Seldaek avatar Dec 09 '20 13:12 Seldaek