barbeau
feat: adding SouthPAN support
Apologies for the mess of commits - I'm new to contributing and managing commits. Let me know if I should start again, or if you've got ideas for tidying it up?
Please make sure these boxes are checked before submitting your pull request - thanks!
-
[x] Acknowledge that you're contributing your code under Apache v2.0 license
-
[x] Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.
@davecollett Thanks for working on this! Don't worry about the many commits, I can squash when I merge. I'll take a look as soon as I can.
Hi @barbeau, could you approve another run of the checks? Hopefully I got all the spots this time!
I think the last lot of tests ran too soon, I've made another correction since.
Using the Dark Theme on the Sky screen, the diamond and dashes in the legend for SouthPAN are showing as black instead of grey.
@davecollett sorry for the delay reviewing this, I haven't had as much spare bandwidth lately.
Where is the image from? We should be sure to credit the source and the license. Could you put the original in the icons folder?
Using the Dark Theme on the Sky screen, the diamond and dashes in the legend for SouthPAN are showing as black instead of grey.
Thanks for flagging this. There is a section of code that manages dark mode on the older sky screen - references to those dashes just need to be added to that section. I'll take a look when I review.
Hi @barbeau - still working on the licencing for the image, will take a look at the other comments soon!
Hey, just saw this open PR after leaving a comment on an old issue about this.
I was just wondering if you had managed to receive the Open SouthPAN signal on a mobile device yet?
I tried on my S22 Ultra but have not had any luck.
Not on my S21+, but it's not reporting it in GNSS Logger either.. I am getting it on my Garmin GPSMAP 62s.
On Tue, 27 Sept 2022 at 17:38, Luke Prior @.***> wrote:
Hey, just saw this open PR after leaving a comment on an old issue about this.
I was just wondering if you had managed to receive the Open SouthPan signal on a mobile device yet?
I tried on my S22 Ultra but have not had any luck.
— Reply to this email directly, view it on GitHub https://github.com/barbeau/gpstest/pull/601#issuecomment-1258965173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKRE2BF7M2FDRV54PEB3LDWAJ26FANCNFSM57NGKNZQ . You are receiving this because you were mentioned.Message ID: @.***>
Just a note that I'm still working on the licensing for the logo - usually the licenses are issued to organisations rather than opensource projects.
Sorry I've taken so long to progress on this (and i hope everything else hasn't moved along too far in the meantime). Although now it looks like there are conflicts with the updated branch?
To clarify- you're after the original logo image, and a source for a license to use it? Where should I put these?
Sorry I've taken so long to progress on this (and i hope everything else hasn't moved along too far in the meantime). Although now it looks like there are conflicts with the updated branch?
No worries, it's never too late. I can help with resolving the conflicts in this PR if needed.
To clarify- you're after the original logo image, and a source for a license to use it? Where should I put these?
I'd like to have the original logo image in the icons folder, and the license should be mentioned in strings.xml <string name="help_text"> tag in the acknowledgements section - you can see another reference to an image license there. You don't need to include the entire license text, just a link would be fine if it's not a standard license like Apache v2.
Ok, I think I've merged everything correctly, and it should have the updated files. Hope I got it into all of the right places!
Seems like it's failing on the Transifex action - possibly an issue with the Secret?
Thanks! Don't worry about Transifex, it's broken right now and I need to fix it.
Thanks @davecollett for continuing to work on this, I'll try to review soon.
Remind me - have we seen SouthPAN on any Android devices yet?
Haven't seen any yet, however I don't know of any apps that would report it other than this. I'm pretty reliant on the reporting from this app to the database to see if its being picked up, and I presume that wouldn't flow through to there at this stage. I've built a version of the app for my phone, but it's a Samsung Galaxy S21+ and it doesn't seem to track any SBAS satellites.
@davecollett Thanks so much for working on this! It will be in the next release. 🎉
Brilliant, thanks! Happy to chip away at any other SBAS related issues too..
On Fri, 21 Apr 2023, 07:07 Sean Barbeau, @.***> wrote:
@davecollett https://github.com/davecollett Thanks so much for working on this! It will be in the next release. 🎉
— Reply to this email directly, view it on GitHub https://github.com/barbeau/gpstest/pull/601#issuecomment-1516812503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKRE2BPGZ7HRE7ZWILHZ53XCGCNPANCNFSM57NGKNZQ . You are receiving this because you were mentioned.Message ID: @.***>
I just tested with this commit and I can't see it on a Samsung S23 either.
Is it showing any SBAS services @andrewharvey? Particularly in eastern Australia you should be able to see some of the Asian SBAS services too.
Is it showing any SBAS services @andrewharvey? Particularly in eastern Australia you should be able to see some of the Asian SBAS services too.
Ah I tested again and it did find one SBAS with the JP flag, CF L1, C/N0 37.5
Cool, thanks! It may be at the chipset level that they're not tracking 122..
In my experience SBAS in general are pretty flaky on Android. They will appear one minute and disappear the next.