vortigern icon indicating copy to clipboard operation
vortigern copied to clipboard

Published 20 hours ago • verified publisher icon barbar

Should we add Object.assign polyfill to client.tsx?

Open bherila opened this issue 7 years ago • 2 comments

per https://stackoverflow.com/questions/35215360/getting-error-object-doesnt-support-property-or-method-assign, this adds IE11 support.

bherila avatar Jun 28 '17 21:06 bherila

Won't typescript handle this based on your target minimum browser javascript support? Its set to es6 atm.

TriStarGod avatar Jul 03 '17 20:07 TriStarGod

Typescript does not polyfill Object.assign, and as discussed in https://github.com/barbar/vortigern/issues/139, setting Typescript to ES6 mode causes problems with Babel transpilation from ES6 ->ES5.

The recommendation from @OR13 was to set Typescript to ES5 but then we have this Object.assign issue.

bherila avatar Jul 03 '17 20:07 bherila