barba icon indicating copy to clipboard operation
barba copied to clipboard

fix(core): timeout reload, go to next page instead

Open nicolas-cusan opened this issue 3 years ago • 3 comments

Fixes #475

nicolas-cusan avatar Oct 26 '21 14:10 nicolas-cusan

Great fix ! When this fix will be released, please ? :)

christophe-glanum avatar Mar 09 '22 08:03 christophe-glanum

This fix seems to make sense: in case there's a problem loading the next page, it makes more sense to try to reload that next page rather than the current one!

I haven't properly tested it though, is there any reason to delay this merge?

thibka avatar Jul 06 '22 20:07 thibka

+1 to get this merged

stepanjakl avatar Jul 28 '22 12:07 stepanjakl

Hi I just moved this from Draft to Open (did not know that that was even a thing with PRs, maybe it is new?). Would be great to get this merged. Thank you!

nicolas-cusan avatar Nov 02 '22 10:11 nicolas-cusan

Hello @nicolas-cusan,

I change the PR state to draft months ago, in order to take time to check/test the fix on my side :+1: Now everything is OK, and I am merging it! :tada:

Sorry for the very long late reply, but we are all busy this year.

The fix shouldn't be available until a new package is released on NPM.

xavierfoucrier avatar Nov 25 '22 11:11 xavierfoucrier

Thank you @xavierfoucrier!

nicolas-cusan avatar Nov 25 '22 13:11 nicolas-cusan