open-fpl icon indicating copy to clipboard operation
open-fpl copied to clipboard

Open FPL logo on side bar got reanimated every time route changed

Open bapairaew opened this issue 4 years ago • 1 comments

To Reproduce Steps to reproduce the behavior:

  1. Go to https://openfpl.com/players
  2. Click on either Fixtures and Team Planner link on the side bar

Expected behavior Open FPL logo stays still

bapairaew avatar Jul 19 '21 08:07 bapairaew

Tried pulling out the logo component and wrapping it with memo(() => <RoughNotation ... />, () => true) to make sure the logo component does not get re-render but it is still reanimated anyway. Might need to debug at library level so will pull this issue out of 1.1.0 and will come back and have a look again later.

bapairaew avatar Jul 23 '21 07:07 bapairaew