istio-operator icon indicating copy to clipboard operation
istio-operator copied to clipboard

[v2] use gogo protobuf fork

Open waynz0r opened this issue 3 years ago • 2 comments

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Use github.com/waynz0r/protobuf gogo protobuf full fork and get rid of the replacement directive in go.mod. The protobuf fork was modified to be a full fork with changed import paths.

Why?

The fork is needed to support int64/uint64 marshalling to integers. Using the fork with replacement in go.mod made the api hard to use as the replacement was necessary everywhere locally.

waynz0r avatar Nov 20 '21 20:11 waynz0r

there are unmarshal issues, i set it to draft for now

waynz0r avatar Nov 23 '21 12:11 waynz0r

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 09 '22 11:06 CLAassistant