ember-infinite-scroll icon indicating copy to clipboard operation
ember-infinite-scroll copied to clipboard

Preparing ember-infinite-scroll for Ember 2.0

Open jackmatt2 opened this issue 11 years ago • 2 comments

I am in the process of converting our project in preparation for Ember 2.0. One of the suggestions is to favour Ember.Controller over Ember.ArrayController and Ember.ObjectController as explained here. The ember-infinite-scroll plugin is the only area left that I was unable to convert as it is using an Ember.ArrayController. Do you know of a way I can convert to Ember.Controller or will this require modifications to the library?

jackmatt2 avatar Nov 17 '14 09:11 jackmatt2

HI, did you try and update this to work with newer ember?

wayne-o avatar Mar 14 '15 17:03 wayne-o

@wayne-o @jackmatt2 Thanks for opening this issue. The infinite-scroll code here is based on a pre-ember-cli globals build style of Ember. It can certainly be integrated with new ember-cli code but overall I think this library should be considered soft-deprecated. Pull requests to bring it up to date would be very welcome, though.

As far as Ember 2.0, you're right, the ArrayController and ObjectController are going away, but updating this to work without those controller types should be pretty straightforward, you'd just need to use an explicit property name for the array of infinitely-scrollable items.

bantic avatar Mar 22 '15 21:03 bantic