vault-operator icon indicating copy to clipboard operation
vault-operator copied to clipboard

Add flag to values.yaml controlling installation of CRDs

Open gecube opened this issue 2 years ago • 2 comments

Preflight Checklist

  • [X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • [X] I agree to follow the Code of Conduct.

Problem Description

Good day colleagues!

I want to leverage the whole GitOps approach and deploy all components of cluster in one go. It also applies to vault operator. The issue is that it is difficult now to make a proper order between different manifests. Let say I want to install

apiVersion: "vault.banzaicloud.com/v1alpha1"
kind: "Vault"
metadata:
  name: "vault"

but I can't do it before I will install the operator itself. It applies to different gitops solutions like ArgoCD and FluxCD. I can overrun it and solve by creation a complex configuration, but I don't like it.

Proposed Solution

Introduce the new flag in the values of helm chart like it's implemented in cert-manager:

https://github.com/cert-manager/cert-manager/issues/2330 https://github.com/cert-manager/cert-manager/blob/5141dddf2c0c5e10c5d4452c99a2e260c6eb2983/deploy/charts/cert-manager/values.yaml#L53

The default value will be installCRDs: true. And the behaviour of the chart won't change. But I will choose installCRDs: false and install CRDs in different kustomization level in proper order.

Alternatives Considered

Split CRDs and the base part of vault operator into different charts (with the synchronous versioning) like it was done in emissary or Linkerd.

Additional Information

No response

gecube avatar Nov 03 '23 10:11 gecube

Hi @gecube, thanks for the feedback, this is definitely something we should be looking at soon!

akijakya avatar Nov 03 '23 20:11 akijakya

Thank you for your contribution! This issue has been automatically marked as stale because it has no recent activity in the last 60 days. It will be closed in 20 days, if no further activity occurs. If this issue is still relevant, please leave a comment to let us know, and the stale label will be automatically removed.

github-actions[bot] avatar Jan 21 '24 00:01 github-actions[bot]