WatchFaceDumper icon indicating copy to clipboard operation
WatchFaceDumper copied to clipboard
verified publisher icon banjun

Added xcode 15 support

Open c2p-cmd opened this issue 2 years ago • 4 comments

Have updated the PodFile to make sure it builds in Xcode 15

c2p-cmd avatar Sep 29 '23 16:09 c2p-cmd

@c2p-cmd thank you for your update!

It seems that the PR contains commits from ongoing PR #3 . You can choose any of these (A or B).

A. change the base branch (target branch) to portrait-watchface, if you use Xcode 15 on portrait-watchface branch B. create a new PR branching on the main branch and make sure that it does not contain any commits on portrait-watchface branch

(If you wish, I can do A for you, when I could have a time for it.)

banjun avatar Oct 02 '23 10:10 banjun

Hey thanks for the response in this case A would be great since I would need support for Portraits Face.

c2p-cmd avatar Oct 02 '23 11:10 c2p-cmd

@c2p-cmd thanks for your second try.

Before I can merge the PR, two changes are needed.

  1. It seems that you are creating PR on your main branch and it includes some future commits (ex. dee72769a867112ee378c08dc3040391900a5f62 ). rewind to cf80aa085b2aafe8ba4314087ec852721f9ab9b2 and make changes on it (screenshot attached for your reference). (Feel free to create another PR with another branch name, if you'd like to do so.)
  2. use CocoaPods 1.13.0 and remove the Podfile workaround script. see https://github.com/banjun/WatchFaceDumper/pull/11#discussion_r1355004308
image

banjun avatar Oct 11 '23 13:10 banjun

Sure will do it 👍

c2p-cmd avatar Oct 11 '23 13:10 c2p-cmd