frontend icon indicating copy to clipboard operation
frontend copied to clipboard

fix: generate typed css module

Open trim21 opened this issue 2 years ago • 10 comments

https://github.com/bangumi/frontend/pull/473#discussion_r1156686423

不太确定是不是需要

vite dev 的情况下会watch *.module.less 然后生成对应的 .d.ts.

试了一下似乎还是得生成 *.module.less.d.ts,生成 *.module.d.less.ts 并不能被正确识别...


这里构建失败是因为之前写的有bug... 这个 editorItemCursor 在runtime是不存在的。

需要 @FoundTheWOUT 修一下

src/pages/index/subject/[id]/components/WikiBeginnerEditor.tsx:84:34 - error TS2339: Property 'editorItemCursor' does not exist on type 'typeof import("C:/Users/Trim21/proj/bangumi/frontend/packages/website/src/pages/index/subject/[id]/components/WikiBeginnerEditor.module.less")'.

84         <Cursor className={style.editorItemCursor} />
                                    ~~~~~~~~~~~~~~~~


Found 1 error in src/pages/index/subject/[id]/components/WikiBeginnerEditor.tsx:84

看来还是有必要的(

trim21 avatar Apr 04 '23 06:04 trim21

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar Apr 04 '23 06:04 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2938c92) 82.43% compared to head (1fa6b2a) 82.43%. Report is 82 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files          98       98           
  Lines        5942     5942           
  Branches      459      459           
=======================================
  Hits         4898     4898           
  Misses       1038     1038           
  Partials        6        6           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 04 '23 07:04 codecov[bot]

Preview Deployment

Build URL time
Sites netlify preview 2023-03-03 05:16:23Z
Storybook netlify preview 2023-03-03 05:18:03Z

github-actions[bot] avatar Apr 04 '23 09:04 github-actions[bot]

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar Apr 04 '23 14:04 mergify[bot]

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar Apr 05 '23 05:04 mergify[bot]

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar May 01 '23 01:05 mergify[bot]

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar Jul 16 '23 16:07 mergify[bot]

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar Aug 23 '23 08:08 mergify[bot]

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar Dec 19 '23 13:12 mergify[bot]

@trim21 this pull request is now in conflict 😩

mergify[bot] avatar May 19 '24 14:05 mergify[bot]