Wolfgang Bangerth

Tetrahedral refinement and FiniteElement::prolongation/restriction.

11

As mentioned in https://github.com/dealii/dealii/pull/16755#issuecomment-2013196180, now that we refine tetrahedra in different ways depending on the cell's geometry, a bunch of things are likely wrong. Specifically (copied from there): I'm coming...

MueLu has a circular header inclusion problem.

11

I can't compile Trilinos 15.1.1 because of a circular header inclusion problem. Specifically, this is the issue: ``` In file included from /.../build/trilinos-release-15-1-1/packages/muelu/src/MueLu_Hierarchy.hpp:2, from /.../unpack/Trilinos-trilinos-release-15-1-1/packages/muelu/src/Headers/MueLu.hpp:69, from /.../unpack/Trilinos-trilinos-release-15-1-1/packages/muelu/src/Operators/MueLu_CreateXpetraPreconditioner.hpp:5 7, from /.../unpack/Trilinos-trilinos-release-15-1-1/packages/muelu/src/Operators/MueLu_RefMaxwell_def.hpp:89,...

Stratimikos creates shared lib with lots of missing symbols.

6

Using the following cmake line: ``` cmake \ -D BUILD_SHARED_LIBS:BOOL=ON \ -D CMAKE_BUILD_TYPE:STRING=RELEASE \ -D CMAKE_CXX_COMPILER=mpicxx \ -D CMAKE_CXX_FLAGS:STRING='-fPIC -g -O3 -march=native' \ -D CMAKE_C_COMPILER=mpicc \ -D CMAKE_C_FLAGS:STRING='-fPIC -g -O3...

Introduce a plugin Manager base class.

2

As discussed in #1771, we have accumulated a good number of `Manager` classes. They all have a number of functions that are really just boilerplate and could be merged into...

Working on #5836 shows that we create plugins in, let's say, an awkward way. In the user's `CMakeLists.txt`, we do ``` ADD_LIBRARY(${TARGET} SHARED prescribed_velocity_ascii_data.cc) ASPECT_SETUP_PLUGIN(${TARGET}) ``` and then (after #5836)...

Avoid bare pointers.

4

We have a number of places where we return bar pointers by functions: ``` include/aspect/material_model/interface.h:453: AdditionalInputType *get_additional_input(); include/aspect/material_model/interface.h:459: const AdditionalInputType *get_additional_input() const; include/aspect/material_model/interface.h:627: AdditionalOutputType *get_additional_output(); include/aspect/material_model/interface.h:633: const AdditionalOutputType *get_additional_output() const;...

#5777 introduces an `include_directories` call that just adds a directory to the include path of *everything*. That ought to be changed to a `target_include_directories` for only those targets that need...

Add an assertion to the computation of the SPD factor.

4

This is a follow-up to #5671 and codifies an assumption in the design of the algorithm by @YiminJin . @naliboff FYI.

Use TARGET_LINK_LIBRARIES instead of DEAL_II_SETUP_TARGET.

3

This should fix #5632, but it does not work. I get the following error: ``` CMake Error at CMakeLists.txt:553 (target_link_libraries): Target "aspect" links to: dealii::dealii_debug but the target was not...

Try using interprocedural/link-time optimization.

3

This is the start of a patch, but I'm having trouble finding out how to finish it. This patch lets cmake query whether the compiler supports LTO, and then I'm...