Wolfgang Bangerth
Wolfgang Bangerth
When mesh deformation plugins compute constraints such as in `diffusion.cc`, they generally do this with code such as ``` for (unsigned int i = 0; i < constrained_dofs.n_elements(); ++i) {...
To the surprise of absolutely nobody who might have followed https://github.com/dealii/dealii/issues/18071, I thought it might be a nice idea to see how much it would take to also convert ASPECT...
In `structured_data.cc`, we do ``` char *filename = static_cast(std::malloc (maxsize * sizeof(char))); int ret = std::snprintf (filename, maxsize, filename_and_path.c_str(), boundary_name.c_str(), filenumber); AssertThrow(ret >= 0, ExcMessage("Invalid string placeholder in filename detected."));...
As discussed in #6538, we should deprecate `SimulatorAccess::get_end_time()` in favor of `this->get_parameters().end_time`.
We have code such as this: ``` const double t = (this->simulator_is_past_initialization()) ? this->get_time() : 0.0; ``` This code is used because if we're still initializing the simulator, the current...
As far as I can see, the arguments to `FastScape::initialize_fastscape()` are all input arguments that are not modified in the function. Our convention is to mark such argument as `const`,...
#6450 is about the fact that we don't tell plugins where to find the WorldBuilder header files. We missed that because nobody apparently had been referencing WorldBuilder header files directly...
We have plenty of places like this (from #6332): ``` std::min (std::max (R1-position.norm(), 0.), maximal_depth()); ``` This code "clamps" the value `R1-position.norm()` to be between zero and `maximal_depth()`. C++17 actually...
This addresses the issues pointed out in #19063. It covers the Trilinos vector, Trilinos Epetra vector class [*], and Trilinos Tpetra vector class. I looked through the PETSc vector class...