scooby icon indicating copy to clipboard operation
scooby copied to clipboard

Published 20 hours ago • verified publisher icon banesullivan

Fix #95

Open prisae opened this issue 2 years ago • 3 comments

Can you test if that works in your env @banesullivan ?

Closes #95

prisae avatar Sep 02 '22 07:09 prisae

(If possible, I'd like to get #93 in before this one.)

prisae avatar Sep 02 '22 07:09 prisae

I'll see if I can reproduce this again... it happened in a pretty complex CI env I was debugging and ended up changing a lot. Or perhaps this might just happen anytime MKL is not installed? I'll find out

banesullivan avatar Sep 02 '22 15:09 banesullivan

Or perhaps this might just happen anytime MKL is not installed?

No, I checked that. If mkl is not installed, it works fine. It must be a weird setup where either mkl.get_version_string() or numexpr.get_vml_version returned None.

However, I think the change in this PR makes the code cleaner, and it should catch this rare case as well.

prisae avatar Sep 02 '22 15:09 prisae

I'll bring that in, whether it fixes it or not, as I think it is better either way.

prisae avatar Oct 28 '22 09:10 prisae